Skip to content

Add initial bcUpgradeTask #128588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Add initial bcUpgradeTask #128588

merged 1 commit into from
Jun 2, 2025

Conversation

@mosche
Copy link
Contributor

@mosche mosche commented May 28, 2025

This can be run as follows until the incompatibility check is removed from TransportService

gradle -Dbwc.checkout.align=true -Dorg.elasticsearch.build.cache.push=true -Dignore.tests.seed -Dscan.capture-file-fingerprints -Dtests.bwc.main.version=9.1.0 -Dtests.bwc.refspec.main=e5cdc581cf7c03903a99eb2adec567294be9ad43 bcUpgradeTest -Dtests.jvm.argline="-Des.serverless_transport=true"

However, this sometimes failed unexpectedly on the upgrade due to an ML issue. When later trying to reproduce to see the actual exception, it didn't reproduce anymore :(

Failure running machine learning native code. This could be due to running on an unsupported OS or distribution, missing OS libraries, or a problem with the temp directory. To bypass this problem by running Elasticsearch without machine learning functionality set [xpack.ml.enabled: false].

Relates to ES-11870

@mosche mosche requested review from a team, ldematte and mark-vieira May 28, 2025 17:03
@mosche mosche added >non-issue :Core/Infra/Core Core issues without another label labels May 28, 2025
@ldematte
Copy link
Contributor

Failure running machine learning native code. This could be due to running on an unsupported OS or distribution, missing OS libraries, or a problem with the temp directory. To bypass this problem by running Elasticsearch without machine learning functionality set [xpack.ml.enabled: false].

I have seen this happening when the native controller does not start. This usually happens to me locally if there is already another controller running, e.g. because a node crashed (or I terminated/broken it in the debugger).
Could it be that we are not cleaning up things? Or just that you ctrl+c the job and left with a controller process hanging there?

@mosche
Copy link
Contributor Author

mosche commented May 30, 2025

I have seen this happening when the native controller does not start. This usually happens to me locally if there is already another controller running, e.g. because a node crashed (or I terminated/broken it in the debugger).
Could it be that we are not cleaning up things? Or just that you ctrl+c the job and left with a controller process hanging there?

You're probably right @ldematte , at some point I did clean up local process manually... not sure what caused them to fail in the first place, but afterwards this worked ok

ldematte
ldematte approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I think this could be merged as-is and then the TODO will be addressed in a follow-up?

@mosche
Copy link
Contributor Author

mosche commented May 30, 2025

I think this could be merged as-is and then the TODO will be addressed in a follow-up?

Yes, that's my intention. Let's keep the initial test set as small as possible to not wait forever while working on this.

@mosche mosche added auto-backport Automatically create backport pull requests when merged v9.0.3 labels May 30, 2025
@mosche mosche marked this pull request as ready for review May 30, 2025 08:21
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 30, 2025
@mosche mosche merged commit cdd2087 into elastic:main Jun 2, 2025
18 checks passed
@mosche mosche mentioned this pull request Jun 2, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.0

mosche added a commit to mosche/elasticsearch that referenced this pull request Jun 2, 2025
@mosche
Add initial bcUpgradeTask (elastic#128588)
28f884d
elasticsearchmachine pushed a commit that referenced this pull request Jun 2, 2025
@mosche
Add initial bcUpgradeTask (#128588) (#128739)
52df16d
mridula-s109 pushed a commit that referenced this pull request Jun 2, 2025
@mosche @mridula-s109
Add initial bcUpgradeTask (#128588)
c5f0aa4
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 3, 2025
@mosche @mridula-s109
Add initial bcUpgradeTask (elastic#128588)
5aab190
joshua-adams-1 pushed a commit to joshua-adams-1/elasticsearch that referenced this pull request Jun 3, 2025
@mosche @joshua-adams-1
Add initial bcUpgradeTask (elastic#128588)
965bb20
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/elasticsearch that referenced this pull request Jun 5, 2025
@mosche @Samiul-TheSoccerFan
Add initial bcUpgradeTask (elastic#128588)
736668e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

@mark-vieira mark-vieira Awaiting requested review from mark-vieira

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v9.0.3 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mosche @ldematte @elasticsearchmachine